Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxManualConfig: set badPlatforms #245963

Merged
merged 1 commit into from Aug 28, 2023
Merged

linuxManualConfig: set badPlatforms #245963

merged 1 commit into from Aug 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2023

This reapplies #237769 following the revert of #221707 in #245449

Description of changes

Older kernels shouldn't be marked as supporting architectures that were only added to the kernel later.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Older kernels shouldn't be marked as supporting architectures that
were only added to the kernel later.
@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Jul 28, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 28, 2023
@Artturin Artturin merged commit a5bf256 into NixOS:staging Aug 28, 2023
6 checks passed
@ghost ghost deleted the pr/linux/kernel/repick branch October 22, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants